Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/120#discussion_r41285023
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java ---
    @@ -54,14 +28,17 @@
     import org.junit.runners.Parameterized;
     import org.junit.runners.Parameterized.Parameters;
     
    -import com.google.common.collect.Lists;
    +import java.sql.*;
    +import java.util.*;
    --- End diff --
    
    Please see https://phoenix.apache.org/contributing.html#Code_conventions. 
You'll want to conform to these - easiest way is to import 
dev/eclipse_prefs_phoenix.epf and dev/phoenix.importorder into Eclipse. This is 
basically to ensure we don't get a lot of code differences due to different 
import ordering and whitespacing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to