Github user maryannxue commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/120#discussion_r42860245
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/DerivedTableIT.java ---
    @@ -313,21 +290,25 @@ public void testDerivedTableWithGroupBy() throws 
Exception {
                 query = "SELECT DISTINCT COLLECTDISTINCT(t.b) FROM (SELECT 
b_string b, a_string a FROM aTable GROUP BY a_string, b_string) AS t GROUP BY 
t.a";
    --- End diff --
    
    @JamesRTaylor Please ignore my previous (deleted) comment. I just realized 
that the server group-by has replaced tree map with hash map, which means an 
optimization I did for client group-by based on the assumption that the input 
is a sorted group-by is now invalid. I will fix this ASAP. And after the fix, 
the test case should fine, we should keep it as it is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to