[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003241#comment-15003241
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/126#discussion_r44733590
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java
 ---
    @@ -35,7 +35,7 @@
     public class ConnectionQueryServicesTestImpl extends 
ConnectionQueryServicesImpl {
         protected int NUM_SLAVES_BASE = 1; // number of slaves for the cluster
         
    -    public ConnectionQueryServicesTestImpl(QueryServices services, 
ConnectionInfo info) throws SQLException {
    +    public ConnectionQueryServicesTestImpl(QueryServices services, 
ConnectionInfo info, Properties info2) throws SQLException {
             super(services, info, null);
    --- End diff --
    
    Should this be passing info2 into the super() instead of null?


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to