[ 
https://issues.apache.org/jira/browse/PHOENIX-1674?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15003287#comment-15003287
 ] 

ASF GitHub Bot commented on PHOENIX-1674:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/126#discussion_r44736280
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java 
---
    @@ -17,428 +17,92 @@
      */
     package org.apache.phoenix.end2end.index;
     
    -import static org.apache.phoenix.util.TestUtil.INDEX_DATA_SCHEMA;
    -import static org.apache.phoenix.util.TestUtil.INDEX_DATA_TABLE;
     import static org.apache.phoenix.util.TestUtil.TEST_PROPERTIES;
     import static org.junit.Assert.assertEquals;
    -import static org.junit.Assert.assertFalse;
     import static org.junit.Assert.assertTrue;
     import static org.junit.Assert.fail;
     
    -import java.math.BigDecimal;
     import java.sql.Connection;
    -import java.sql.Date;
     import java.sql.DriverManager;
    -import java.sql.PreparedStatement;
     import java.sql.ResultSet;
     import java.sql.SQLException;
    +import java.sql.Statement;
    +import java.util.Arrays;
    +import java.util.Collection;
     import java.util.Properties;
     
     import org.apache.phoenix.end2end.BaseHBaseManagedTimeIT;
     import org.apache.phoenix.exception.SQLExceptionCode;
    -import org.apache.phoenix.jdbc.PhoenixConnection;
    -import org.apache.phoenix.query.QueryConstants;
    -import org.apache.phoenix.schema.PTableKey;
    -import org.apache.phoenix.util.DateUtil;
    +import org.apache.phoenix.query.BaseTest;
     import org.apache.phoenix.util.PropertiesUtil;
    -import org.apache.phoenix.util.QueryUtil;
    +import org.apache.phoenix.util.SchemaUtil;
    +import org.apache.phoenix.util.TestUtil;
     import org.junit.Test;
    +import org.junit.runner.RunWith;
    +import org.junit.runners.Parameterized;
    +import org.junit.runners.Parameterized.Parameters;
     
     
    +@RunWith(Parameterized.class)
    --- End diff --
    
    If easy, can we do this test improvement in a separate change in master to 
reduce the noise here?


> Snapshot isolation transaction support through Tephra
> -----------------------------------------------------
>
>                 Key: PHOENIX-1674
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1674
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: James Taylor
>              Labels: SFDC
>
> Tephra (http://tephra.io/ and https://github.com/caskdata/tephra) is one 
> option for getting transaction support in Phoenix. Let's use this JIRA to 
> discuss the way in which this could be integrated along with the pros and 
> cons.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to