Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44852631
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -1386,7 +1430,7 @@ public MutationState 
createFunction(CreateFunctionStatement stmt) throws SQLExce
                     FunctionArgument arg = args.get(i);
                     addFunctionArgMutation(function.getFunctionName(), arg, 
argUpsert, i);
                 }
    -            
functionData.addAll(connection.getMutationState().toMutations().next().getSecond());
    +            
functionData.addAll(connection.getMutationState().toMutations(null).next().getSecond());
    --- End diff --
    
    This toMutations(null) looks a little funky. Maybe overload it so the null 
isn't required?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to