Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44852894
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -2578,17 +2745,18 @@ public MutationState addColumn(AddColumnStatement 
statement) throws SQLException
                         }
                     }
     
    -                if (numPkColumnsAdded>0 && !table.getIndexes().isEmpty()) {
    +                if (!table.getIndexes().isEmpty() && (numPkColumnsAdded>0 
|| nonTxToTx)) {
                         for (PTable index : table.getIndexes()) {
    -                        incrementTableSeqNum(index, index.getType(), 
numPkColumnsAdded);
    +                        incrementTableSeqNum(index, index.getType(), 
numPkColumnsAdded, nonTxToTx ? Boolean.TRUE : null);
                         }
    -                    
tableMetaData.addAll(connection.getMutationState().toMutations().next().getSecond());
    +                    
tableMetaData.addAll(connection.getMutationState().toMutations(timeStamp).next().getSecond());
                         connection.rollback();
                     }
                     long seqNum = table.getSequenceNumber();
                     if (changingPhoenixTableProperty || columnDefs.size() > 0) 
{ 
    -                    seqNum = incrementTableSeqNum(table, 
statement.getTableType(), columnDefs.size(), isImmutableRows, disableWAL, 
multiTenant, storeNulls);
    -                    
tableMetaData.addAll(connection.getMutationState().toMutations().next().getSecond());
    +                    // TODO: verify master has fix for multiple data 
columns added and unit test
    --- End diff --
    
    Remove TODO please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to