Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/127#discussion_r44853223
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsCollectorWithSplitsAndMultiCFIT.java
 ---
    @@ -176,7 +176,7 @@ public void testSplitUpdatesStats() throws Exception {
             Collection<GuidePostsInfo> infos = 
TestUtil.getGuidePostsList(conn, STATS_TEST_TABLE_NAME);
             for (GuidePostsInfo info : infos) {
                 assertEquals(20, info.getRowCount());
    -            assertEquals(11020, info.getByteCount());
    +            assertEquals(11040, info.getByteCount());
    --- End diff --
    
    I believe it's because our empty column value isn't empty any longer. We 
need it to have a value so that Tephra doesn't treat it as a delete marker. We 
could conditionally use an empty value if the table is non transactional, but 
meh.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to