[ 
https://issues.apache.org/jira/browse/PHOENIX-2437?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014832#comment-15014832
 ] 

James Taylor commented on PHOENIX-2437:
---------------------------------------

I didn't know about this other shutdown hook. If we can get away without doing 
the Class.forName(PhoenixDriver.class.getName()), then we can remove some hacks 
I added to force the test driver not to be used. For example, in BasePigIT:
{code}
    @BeforeClass
    @Shadower(classBeingShadowed = BaseHBaseManagedTimeIT.class)
    public static void doSetup() throws Exception {
        Map<String,String> props = Maps.newHashMapWithExpectedSize(3);
        props.put(QueryServices.EXTRA_JDBC_ARGUMENTS_ATTRIB, 
QueryServicesOptions.DEFAULT_EXTRA_JDBC_ARGUMENTS);
        // Must update config before starting server
        setUpTestDriver(new ReadOnlyProps(props.entrySet().iterator()));
    }
{code}

One question is what is going to register the driver for a Mapper that's using 
Phoenix? Will the regular auto load of the driver work, [~mujtabachohan] or 
[~gabriel.reid]?

> Build times out intermittently
> ------------------------------
>
>                 Key: PHOENIX-2437
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2437
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>         Attachments: PHOENIX-2437.patch
>
>
> Looks like our build is timing out still, even with my change for 
> PHOENIX-2427. [~mujtabachohan] - any insight into the new failures? 
> [~samarthjain] - I'm thinking we should remove the shutdown hook altogether 
> and live with exceptions that can occur when a server is going down while 
> connection are still being attempted to be gotten.
> WDYT?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to