[ 
https://issues.apache.org/jira/browse/PHOENIX-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15086990#comment-15086990
 ] 

James Taylor commented on PHOENIX-2368:
---------------------------------------

Is this ready to go, [~ram_krish]? Should be a one liner change in 
PhoenixDriver (probably same in PhoenixTestDriver if you want to be consistent) 
plus the test (that's already written).

> Call Driver.accept() in Driver.getConnection and return null if false
> ---------------------------------------------------------------------
>
>                 Key: PHOENIX-2368
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2368
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: James Taylor
>            Assignee: ramkrishna.s.vasudevan
>              Labels: SFDC, newbie
>             Fix For: 4.7.0
>
>
> The driver should return "null" if it realizes it is the wrong kind of driver 
> to connect to the given URL.
> Your driver is throwing an exception instead of returning null.
> Here's the start of a test case:
> {code}
> public static void main(String[] args) throws Exception {
>     Class.forName(PhoenixDriver.class.getName());
>     PhoenixDriver d = (PhoenixDriver) DriverManager.getDriver("jdbc:phoenix");
>     d.close();
>     DriverManager.getConnection("any text whatever you want to put here");
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to