[
https://issues.apache.org/jira/browse/PHOENIX-2368?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15087059#comment-15087059
]
Hadoop QA commented on PHOENIX-2368:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12780931/PHOENIX-2368.patch
against master branch at commit b06e0fc0c0cf256e07c7545189ae06740009375e.
ATTACHMENT ID: 12780931
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
33 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.phoenix.query.ConnectionlessTest
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
at
org.apache.camel.test.junit4.CamelTestSupport.assertMockEndpointsSatisfied(CamelTestSupport.java:742)
at
org.apache.camel.component.stream.StreamGroupLinesTest.testGroupLines(StreamGroupLinesTest.java:68)
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/215//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/215//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/215//console
This message is automatically generated.
> Call Driver.accept() in Driver.getConnection and return null if false
> ---------------------------------------------------------------------
>
> Key: PHOENIX-2368
> URL: https://issues.apache.org/jira/browse/PHOENIX-2368
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: ramkrishna.s.vasudevan
> Labels: SFDC, newbie
> Fix For: 4.7.0
>
> Attachments: PHOENIX-2368.patch, PHOENIX-2368.patch
>
>
> The driver should return "null" if it realizes it is the wrong kind of driver
> to connect to the given URL.
> Your driver is throwing an exception instead of returning null.
> Here's the start of a test case:
> {code}
> public static void main(String[] args) throws Exception {
> Class.forName(PhoenixDriver.class.getName());
> PhoenixDriver d = (PhoenixDriver) DriverManager.getDriver("jdbc:phoenix");
> d.close();
> DriverManager.getConnection("any text whatever you want to put here");
> }
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
