[ https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210466#comment-15210466 ]
ASF GitHub Bot commented on PHOENIX-1311: ----------------------------------------- Github user samarthjain commented on a diff in the pull request: https://github.com/apache/phoenix/pull/153#discussion_r57341237 --- Diff: phoenix-core/src/it/java/org/apache/phoenix/end2end/CreateTableIT.java --- @@ -94,6 +99,8 @@ public void testCreateTable() throws Exception { " id INTEGER not null primary key desc\n" + " ) "; conn.createStatement().execute(ddl); + HBaseAdmin admin = driver.getConnectionQueryServices(getUrl(), props).getAdmin(); + assertNotEquals(null, admin.getTableDescriptor(Bytes.toBytes(tableName))); --- End diff -- Minor nits: assertNotNull reads better here. Same recommendations as above regarding getting and closing HBaseAdmin. > HBase namespaces surfaced in phoenix > ------------------------------------ > > Key: PHOENIX-1311 > URL: https://issues.apache.org/jira/browse/PHOENIX-1311 > Project: Phoenix > Issue Type: New Feature > Reporter: nicolas maillard > Assignee: Ankit Singhal > Priority: Minor > Fix For: 4.8.0 > > Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, > PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch > > > Hbase (HBASE-8015) has the concept of namespaces in the form of > myNamespace:MyTable it would be great if Phoenix leveraged this feature to > give a database like feature on top of the table. > Maybe to stay close to Hbase it could also be a create DB:Table... > or DB.Table which is a more standard annotation? -- This message was sent by Atlassian JIRA (v6.3.4#6332)