[
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15210709#comment-15210709
]
ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/153#discussion_r57364562
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -825,9 +825,27 @@ protected static void ensureTableCreated(String url,
String tableName, Long ts)
protected static void ensureTableCreated(String url, String tableName,
byte[][] splits, Long ts) throws SQLException {
String ddl = tableDDLMap.get(tableName);
+ createSchema(url,tableName, ts);
createTestTable(url, ddl, splits, ts);
}
+ public static void createSchema(String url, String tableName, Long ts)
throws SQLException {
+ if (tableName.contains(".")) {
+ String schema = tableName.substring(0, tableName.indexOf("."));
+ if (!schema.equals("")) {
+ Properties props = new Properties();
+ if (ts != null) {
+ props.setProperty(PhoenixRuntime.CURRENT_SCN_ATTRIB,
Long.toString(ts));
+ }
+ try (Connection conn = DriverManager.getConnection(url,
props);) {
+ conn.createStatement().executeUpdate("CREATE SCHEMA IF
NOT EXISTS " + schema);
+ } catch (TableAlreadyExistsException e) {
--- End diff --
Remove the catch() block here as it doesn't apply.
> HBase namespaces surfaced in phoenix
> ------------------------------------
>
> Key: PHOENIX-1311
> URL: https://issues.apache.org/jira/browse/PHOENIX-1311
> Project: Phoenix
> Issue Type: New Feature
> Reporter: nicolas maillard
> Assignee: Ankit Singhal
> Priority: Minor
> Fix For: 4.8.0
>
> Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch,
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
