[ 
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214032#comment-15214032
 ] 

ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------

Github user ankitsinghal commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r57558752
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
 ---
    @@ -634,15 +642,19 @@ private PMetaData metaDataMutated(PName tenantId, 
String tableName, long tableSe
             }
          }
     
    -    @Override
    -    public PMetaData addColumn(final PName tenantId, final String 
tableName, final List<PColumn> columns, final long tableTimeStamp, 
    -            final long tableSeqNum, final boolean isImmutableRows, final 
boolean isWalDisabled, final boolean isMultitenant, 
    -            final boolean storeNulls, final boolean isTransactional, final 
long updateCacheFrequency, final long resolvedTime) throws SQLException {
    -        return metaDataMutated(tenantId, tableName, tableSeqNum, new 
Mutator() {
    +   @Override
    --- End diff --
    
    No, isNamespaceMapped parameter is added.


> HBase namespaces surfaced in phoenix
> ------------------------------------
>
>                 Key: PHOENIX-1311
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1311
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: nicolas maillard
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, 
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of 
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to 
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to