[ 
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15214291#comment-15214291
 ] 

ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------

Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/153#discussion_r57581391
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/schema/MetaDataClient.java ---
    @@ -544,7 +556,28 @@ private MetaDataMutationResult updateCache(PName 
tenantId, String schemaName, St
     
             return result;
         }
    -    
    +
    +    public MetaDataMutationResult updateCache(String schemaName) throws 
SQLException {
    +        return updateCache(schemaName, false);
    +    }
    +
    +    public MetaDataMutationResult updateCache(String schemaName, boolean 
alwaysHitServer) throws SQLException {
    +        long clientTimeStamp = getClientTimeStamp();
    +        PSchema schema = null;
    +        try {
    +            schema = connection.getMetaDataCache().getSchema(new 
PTableKey(null, schemaName));
    --- End diff --
    
    No, we wouldn't need a schema per tenantId. With namespace support, is all 
data still stored in the same physical table for all views, even if the views 
have different schemas? For example, given the following:
    
        CREATE VIEW s1.a AS SELECT * FROM t WHERE k=1;
        CREATE VIEW s2.b AS SELECT * FROM t WHERE k=2;
        CREATE VIEW s3.c AS SELECT * FROM t WHERE k=3;
    
    Would the following query still return all rows across all three views?
    
        SELECT * FROM t;


> HBase namespaces surfaced in phoenix
> ------------------------------------
>
>                 Key: PHOENIX-1311
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1311
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: nicolas maillard
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, 
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of 
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to 
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to