Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58479273
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java
---
@@ -165,7 +183,7 @@ public RegionScanner preScannerOpen(final
ObserverContext<RegionCoprocessorEnvir
scan.setTimeRange(timeRange.getMin(), Bytes.toLong(txnScn));
}
if (isRegionObserverFor(scan)) {
- if (! skipRegionBoundaryCheck(scan)) {
+ if (! skipRegionBoundaryCheck(scan) ||
ScanUtil.isLocalIndex(scan)) {
--- End diff --
Add comment, please. Something like this:
// For local indexes, we need to throw if out of region as we'll get
duplicates otherwise while in other cases,
// it may just mean out client-side data on region boundaries is out of
date and can safely be ignored.
Note that we'll need to handle this from the MR integration which might be
painful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
