Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58482075
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
 ---
    @@ -402,8 +405,8 @@ private RegionScanner 
scanUnordered(ObserverContext<RegionCoprocessorEnvironment
                 }
     
                 Region region = c.getEnvironment().getRegion();
    -            region.startRegionOperation();
                 try {
    +                region.startRegionOperation();
    --- End diff --
    
    Doesn't startRegionOperation() take a lock which would prevent a split from 
occurring and thus a NotServingRegionException from happening? Or is this the 
case where the split occurred after pre open, but before we start iterating? 
Let's doc that please.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to