[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227368#comment-15227368
]
ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58632305
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/compile/ScanRanges.java ---
@@ -385,9 +387,25 @@ public Scan intersectScan(Scan scan, final byte[]
originalStartKey, final byte[]
if (scanStopKey.length > 0 && Bytes.compareTo(scanStartKey,
scanStopKey) >= 0) {
return null;
}
- newScan.setAttribute(SCAN_ACTUAL_START_ROW, scanStartKey);
- newScan.setStartRow(scanStartKey);
- newScan.setStopRow(scanStopKey);
+ if(ScanUtil.isLocalIndex(scan)) {
--- End diff --
@JamesRTaylor we cannot use keyoffset > 0 check always for considering
local indexes scan because in special case like if a table has only one region
then region start key length and end key length is zero so keyoffset also
becoming zero. In that case we need to check local index scan or not to set the
attributes properly. Wdyt?
> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
> Key: PHOENIX-2628
> URL: https://issues.apache.org/jira/browse/PHOENIX-2628
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch,
> PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for
> scans and aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
