[
https://issues.apache.org/jira/browse/PHOENIX-2628?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15227501#comment-15227501
]
ASF GitHub Bot commented on PHOENIX-2628:
-----------------------------------------
Github user chrajeshbabu commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/156#discussion_r58639845
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/iterate/TableResultIterator.java
---
@@ -80,13 +94,19 @@
};
- public TableResultIterator(MutationState mutationState, TableRef
tableRef, Scan scan, CombinableMetric scanMetrics, long renewLeaseThreshold)
throws SQLException {
+ public TableResultIterator(MutationState mutationState, Scan scan,
CombinableMetric scanMetrics, long renewLeaseThreshold, QueryPlan plan) throws
SQLException {
+ this(mutationState, scan, scanMetrics, renewLeaseThreshold, plan,
false);
+ }
+
+ public TableResultIterator(MutationState mutationState, Scan scan,
CombinableMetric scanMetrics, long renewLeaseThreshold, QueryPlan plan, boolean
handleSplitRegionBoundaryFailureDuringInitialization) throws SQLException {
this.scan = scan;
this.scanMetrics = scanMetrics;
- PTable table = tableRef.getTable();
+ PTable table = plan.getTableRef().getTable();
htable = mutationState.getHTable(table);
this.scanIterator = UNINITIALIZED_SCANNER;
this.renewLeaseThreshold = renewLeaseThreshold;
+ this.plan = plan;
+ this.handleSplitRegionBoundaryFailureDuringInitialization =
handleSplitRegionBoundaryFailureDuringInitialization;
--- End diff --
handleSplitRegionBoundaryFailureDuringInitialization will be true for
scanning intermediate chunks in ChunkedResultIterator. When we create scanner
for new chunk we might see stale region boundaries in that case also we need to
forcibly recreate the iterator with new boundaries. In normal case if we get
StaleRegionBoundary exception while creating scanner BaseResultIterator handles
it.
> Ensure split when iterating through results handled correctly
> -------------------------------------------------------------
>
> Key: PHOENIX-2628
> URL: https://issues.apache.org/jira/browse/PHOENIX-2628
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Rajeshbabu Chintaguntla
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2628-wip.patch, PHOENIX-2628.patch,
> PHOENIX-2628_v7.patch, PHOENIX-2628_v8.patch
>
>
> We should start with a test case to ensure this works correctly, both for
> scans and aggregates.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
