Github user chrajeshbabu commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/156#discussion_r58638568
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GroupedAggregateRegionObserver.java
 ---
    @@ -423,7 +426,14 @@ private RegionScanner 
scanUnordered(ObserverContext<RegionCoprocessorEnvironment
                             }
                         } while (hasMore && groupByCache.size() < limit);
                     }
    -            } finally {
    +            }  catch(NotServingRegionException e){
    +                if(ScanUtil.isLocalIndex(scan)) {
    +                    Exception cause = new 
StaleRegionBoundaryCacheException(c.getEnvironment().getRegion().getRegionInfo().getTable().getNameAsString());
    +                    throw new DoNotRetryIOException(cause.getMessage(), 
cause);
    +                } else {
    +                    throw e;
    --- End diff --
    
    There is a chance of split can happen after preScannerOpen and before 
postScannerOpen. I think we can throw stale region boundary exception all the 
cases because even when we throw NSRE we again need to open the scanner which 
checks the region boundaries and throw the stale region boundary exception any 
way. Will check it once.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to