[
https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15232672#comment-15232672
]
Sergey Soldatov commented on PHOENIX-2535:
------------------------------------------
[~elserj]
{quote}
Ok. Yeah, if we're doing things correctly, the client should never have to have
the phoenix-[query]server jar's classes. Regarding the thin client jar now, we
do have a shaded artifact
(phoenix-server-client/target/phoenix-4.8.0-HBase-1.1-SNAPSHOT-thin-client.jar),
but the shaded classes aren't relocated. That was the other half of my
question – did I miss you doing that in your patch? I think that was in the
original spirit of the JIRA issue's title.
{quote}
Yep, at the beginning we have discussed what exactly need to be shaded. And it
seems that phoenix-server-client nobody mentioned. I will add shading for this
module.
> Create shaded clients (thin + thick)
> -------------------------------------
>
> Key: PHOENIX-2535
> URL: https://issues.apache.org/jira/browse/PHOENIX-2535
> Project: Phoenix
> Issue Type: Bug
> Reporter: Enis Soztutar
> Assignee: Sergey Soldatov
> Fix For: 4.8.0
>
> Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch,
> PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch
>
>
> Having shaded client artifacts helps greatly in minimizing the dependency
> conflicts at the run time. We are seeing more of Phoenix JDBC client being
> used in Storm topologies and other settings where guava versions become a
> problem.
> I think we can do a parallel artifact for the thick client with shaded
> dependencies and also using shaded hbase. For thin client, maybe shading
> should be the default since it is new?
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
