[ https://issues.apache.org/jira/browse/PHOENIX-2535?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15233052#comment-15233052 ]
ASF GitHub Bot commented on PHOENIX-2535: ----------------------------------------- Github user enis commented on a diff in the pull request: https://github.com/apache/phoenix/pull/159#discussion_r59096272 --- Diff: pom.xml --- @@ -27,9 +27,11 @@ <module>phoenix-flume</module> <module>phoenix-pig</module> <module>phoenix-server-client</module> - <module>phoenix-server</module> --- End diff -- I like the phoenix-queryserver and phoenix-queryserver-client as names of the modules. phoenix-server-client is hard to parse without knowing phoenix-server is phoenix query server. > Create shaded clients (thin + thick) > ------------------------------------- > > Key: PHOENIX-2535 > URL: https://issues.apache.org/jira/browse/PHOENIX-2535 > Project: Phoenix > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Sergey Soldatov > Fix For: 4.8.0 > > Attachments: PHOENIX-2535-1.patch, PHOENIX-2535-2.patch, > PHOENIX-2535-3.patch, PHOENIX-2535-4.patch, PHOENIX-2535-5.patch > > > Having shaded client artifacts helps greatly in minimizing the dependency > conflicts at the run time. We are seeing more of Phoenix JDBC client being > used in Storm topologies and other settings where guava versions become a > problem. > I think we can do a parallel artifact for the thick client with shaded > dependencies and also using shaded hbase. For thin client, maybe shading > should be the default since it is new? -- This message was sent by Atlassian JIRA (v6.3.4#6332)