[ 
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238812#comment-15238812
 ] 

ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------

Github user ankitsinghal commented on the pull request:

    https://github.com/apache/phoenix/pull/153#issuecomment-209296286
  
    @samarthjain 
    
    > Will the table T be created in the namespace S? If the feature is 
disabled, it shouldn't be. Would you mind adding a test for this if it hasn't 
been already?
    
    Yes, table T will not be created in namespace S if isNamespaceMapped is 
disabled. Test is there in CreateTableIT#testCreateTable
    
    > Also, how about if we do a CREATE TABLE SCHEMA.TABLENAME with the feature 
on. Does it end up creating the namespace named SCHEMA first and then maps the 
table to that namespace
    
    If features is on and SCHEMA is not already present it will fail with 
SchemaNotFoundException. User has to create a schema first and then he can 
create a table if the config is set to true.
    but when config is set to false, it will create a table with name 
SCHEMA.TABLENAME in default namespace without throwing any 
SchemaNotFoundException.
    I have added a test(CreateTableIT#testCreateTableWithoutSchema) in the 
latest commit for the same.
    
    
    
    
    
    
    
    



> HBase namespaces surfaced in phoenix
> ------------------------------------
>
>                 Key: PHOENIX-1311
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1311
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: nicolas maillard
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, 
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of 
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to 
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to