[ 
https://issues.apache.org/jira/browse/PHOENIX-1311?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15238857#comment-15238857
 ] 

ASF GitHub Bot commented on PHOENIX-1311:
-----------------------------------------

Github user ankitsinghal commented on the pull request:

    https://github.com/apache/phoenix/pull/153#issuecomment-209304973
  
    @JamesRTaylor ,
    
    > There are likely lots of issues if isNamespaceMapping config property 
changes from true to false, no? 
    
    There will not be any problem if 
**phoenix.connection.isNamespaceMappingEnabled** is set from true to false 
unless the system tables are migrated after setting 
**"phoenix.connection.mapSystemTablesToNamespace"** to true as it will migrate 
the SYSTEM tables to SYSTEM namespace and it is need to be set at client and 
server both to have IndexFailure, stats collection to work correctly which 
directly refers system tables at server. Let me know if name of the properties 
needs to be change to depict it as server and client side property.
    
    >  Wouldn't existing namespace mapped tables not be found if it was changed 
from true to false after tables had been created?
    
    Tables mapped will still be accessible. Although old client(<v4.8) will not 
be able to access tables mapped to namespace
    
    > What would be the purpose of allowing a schema (namespace) to be created 
if the feature is off?If none, then it's probably best to give an error message 
if isNamespaceMapping is off and CREATE SCHEMA is used.
    
    Yes, I think we can through exception during CREATE SCHEMA only if the 
property is not set .
    but other constructs (like USE <SCHEMA>) should still be allowed as mapped 
tables are accessible even isNamespaceMappingEnabled is set to false.
    
    
    
     
    
    
    
    
    
    
    



> HBase namespaces surfaced in phoenix
> ------------------------------------
>
>                 Key: PHOENIX-1311
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-1311
>             Project: Phoenix
>          Issue Type: New Feature
>            Reporter: nicolas maillard
>            Assignee: Ankit Singhal
>            Priority: Minor
>             Fix For: 4.8.0
>
>         Attachments: PHOENIX-1311.docx, PHOENIX-1311_v1.patch, 
> PHOENIX-1311_v2.patch, PHOENIX-1311_wip.patch, PHOENIX-1311_wip_2.patch
>
>
> Hbase (HBASE-8015) has the concept of namespaces in the form of 
> myNamespace:MyTable it would be great if Phoenix leveraged this feature to 
> give a database like feature on top of the table.
> Maybe to stay close to Hbase it could also be a create DB:Table...
> or DB.Table which is a more standard annotation?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to