[ 
https://issues.apache.org/jira/browse/PHOENIX-2865?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267199#comment-15267199
 ] 

James Taylor commented on PHOENIX-2865:
---------------------------------------

Thanks for the patch, [~ankit.singhal]. Here's some feedback:
- Make BaseResultIterators {{private boolean useStats()}} method protected.
- Override it on SerialIterators to return false.
- FWIW, in general you wouldn't want to check for the hint to decide things, as 
hints are "recommendations" given to the optimizer from the user. In reality, 
the optimizer may decide that the statement cannot be run serially, for example 
(in which case SerialIterators would not be used).

> We should not use GuidePosts when we are running query in serial
> ----------------------------------------------------------------
>
>                 Key: PHOENIX-2865
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2865
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Ankit Singhal
>            Assignee: Ankit Singhal
>            Priority: Minor
>         Attachments: PHOENIX-2865.patch
>
>
> Although it conflict a little with the work done in PHOENIX-2724 ,but I think 
> , query with serial Hint or serial query (non-orderby query with limit/offset 
> on non-salted/non-local index table) should not use guidePosts as it is 
> unnecessary.
> [~jamestaylor]/[~samarthjain], WDYT?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to