[ 
https://issues.apache.org/jira/browse/PHOENIX-2914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15290659#comment-15290659
 ] 

Junegunn Choi commented on PHOENIX-2914:
----------------------------------------

[~sergey.soldatov] Thanks, I'm aware of the code (I mentioned about 
{{phoenix_utils.hbase_conf_dir}} above). However, sqlline.py also looks for 
{{hbase-env.sh}} in the directory where {{phoenix_utils.py}} is located when 
{{HBASE_CONF_DIR}} is not defined 
(https://github.com/apache/phoenix/blob/4ee0989/bin/sqlline.py#L53), so I 
figured that the original intention here is to load configuration files in the 
bin directory. The patch does not replace the path from phoenix_utils in the 
classpath, but adds {{bin}} directory to it when {{HBASE_CONF_DIR}} is not 
specified.

> Make sqlline refer to bin/hbase-site.xml by default
> ---------------------------------------------------
>
>                 Key: PHOENIX-2914
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-2914
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Junegunn Choi
>            Priority: Minor
>         Attachments: PHOENIX-2914.patch
>
>
> I expected sqlline to pick up the settings in {{bin/hbase-site.xml}} by 
> default, but it didn't unless I set up {{HBASE_CONF_DIR}} to point to the 
> {{bin}} directory.
> An easy solution would be to simply prepend {{hbase_config_path}} to the 
> classpath. {{hbase_config_path}} and {{phoenix_utils.hbase_conf_dir}} will 
> point to the same directory when {{HBASE_CONF_DIR}} is set, but having it 
> twice in classpath will not cause any problem.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to