[ 
https://issues.apache.org/jira/browse/PHOENIX-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373124#comment-15373124
 ] 

James Taylor commented on PHOENIX-3045:
---------------------------------------

Looks like a patch for PHOENIX-3063. I think you forgot to add the new 
RecoveryIndexWriter class too. Would you mind creating a method like this for 
better abstraction, though:
{code}
public boolean isStatsEnabled(String fullTableName) {
    return !DISABLE_STATS.contains(TableName.valueOf(fullTableName));
}
{code}
Otherwise, it looks good.

> Data regions in transition forever if RS holding them down during drop index
> ----------------------------------------------------------------------------
>
>                 Key: PHOENIX-3045
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3045
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Sergio Peleato
>            Assignee: Ankit Singhal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3045.patch, PHOENIX-3045_v1.patch
>
>
> There is a chance that region server holding the data regions might abruptly 
> killed before flushing the data table this leads same failure case that data 
> regions won't be opened which leads to the regions in transition forever. We 
> need to handle this case by checking dropped indexes on recovery write 
> failures and skip the corresponding mutations to write to them.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to