[
https://issues.apache.org/jira/browse/PHOENIX-3045?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15373232#comment-15373232
]
James Taylor commented on PHOENIX-3045:
---------------------------------------
One very minor fix on commit nit. Can you change this so that it doesn't create
a new TableName instance each time?
{code}
private static boolean statisticsEnabled(RegionCoprocessorEnvironment env)
{
return
env.getConfiguration().getBoolean(QueryServices.STATS_ENABLED_ATTRIB, true) &&
- !DISABLE_STATS.contains(env.getRegionInfo().getTable());
+
StatisticsUtil.isStatsEnabled(TableName.valueOf(env.getRegionInfo().getTable().getName()));
{code}
change to:
{code}
private static boolean statisticsEnabled(RegionCoprocessorEnvironment env)
{
return
env.getConfiguration().getBoolean(QueryServices.STATS_ENABLED_ATTRIB, true) &&
- !DISABLE_STATS.contains(env.getRegionInfo().getTable());
+ StatisticsUtil.isStatsEnabled(env.getRegionInfo().getTable());
{code}
> Data regions in transition forever if RS holding them down during drop index
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-3045
> URL: https://issues.apache.org/jira/browse/PHOENIX-3045
> Project: Phoenix
> Issue Type: Bug
> Reporter: Sergio Peleato
> Assignee: Ankit Singhal
> Fix For: 4.8.0
>
> Attachments: PHOENIX-3045.patch, PHOENIX-3045_v1.patch,
> PHOENIX-3045_v2.patch
>
>
> There is a chance that region server holding the data regions might abruptly
> killed before flushing the data table this leads same failure case that data
> regions won't be opened which leads to the regions in transition forever. We
> need to handle this case by checking dropped indexes on recovery write
> failures and skip the corresponding mutations to write to them.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
