[
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415751#comment-15415751
]
ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------
Github user samarthjain commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/189#discussion_r74304816
--- Diff: phoenix-core/src/test/java/org/apache/phoenix/query/BaseTest.java
---
@@ -1052,16 +1057,20 @@ private static void deletePriorSequences(long ts,
Connection globalConn) throws
}
rs.close();
}
-
+
protected static void initSumDoubleValues(byte[][] splits, String url)
throws Exception {
- ensureTableCreated(url, "SumDoubleTest", splits);
+ initSumDoubleValues("SumDoubleTest", splits, url);
+ }
+
+ protected static void initSumDoubleValues(String tableName, byte[][]
splits, String url) throws Exception {
+ ensureTableCreated(url, tableName, "SumDoubleTest", splits);
--- End diff --
Minor nit: Define a static constant for SumDoubleTest like other table ddl
types.
> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
> Key: PHOENIX-3036
> URL: https://issues.apache.org/jira/browse/PHOENIX-3036
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: prakul agarwal
> Fix For: 4.9.0
>
> Attachments: PHOENIX-3036.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
