[ 
https://issues.apache.org/jira/browse/PHOENIX-3036?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15415796#comment-15415796
 ] 

ASF GitHub Bot commented on PHOENIX-3036:
-----------------------------------------

Github user samarthjain commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/189#discussion_r74309672
  
    --- Diff: 
phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicColumnIT.java ---
    @@ -59,16 +59,18 @@
      */
     
     
    -public class DynamicColumnIT extends BaseHBaseManagedTimeIT {
    +public class DynamicColumnIT extends BaseHBaseManagedTimeTableReuseIT {
         private static final byte[] FAMILY_NAME_A = 
Bytes.toBytes(SchemaUtil.normalizeIdentifier("A"));
         private static final byte[] FAMILY_NAME_B = 
Bytes.toBytes(SchemaUtil.normalizeIdentifier("B"));
     
    +    private String tableName = "TESTTBL";
    --- End diff --
    
    Shouldn't the name be generated by generateRandomString() ?


> Modify phoenix IT tests to extend BaseHBaseManagedTimeTableReuseIT
> ------------------------------------------------------------------
>
>                 Key: PHOENIX-3036
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3036
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: prakul agarwal
>             Fix For: 4.9.0
>
>         Attachments: PHOENIX-3036.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to