[
https://issues.apache.org/jira/browse/PHOENIX-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428993#comment-15428993
]
Hadoop QA commented on PHOENIX-808:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12824646/PHOENIX-808_v2_master.patch
against master branch at commit 386cbbbf7a5dd736888e8e0bfe16e513d54e215c.
ATTACHMENT ID: 12824646
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
34 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ public static final String CURRENT_CLIENT_VERSION =
PHOENIX_MAJOR_VERSION + "." + PHOENIX_MINOR_VERSION + "." +
PHOENIX_PATCH_NUMBER;
+ sysCatalogTableName =
e.getTable().getPhysicalName().getString();
+ if (currentServerSideTableTimeStamp <
MIN_SYSTEM_TABLE_TIMESTAMP) {
+ snapshotName =
getUpgradeSnapshotName(sysCatalogTableName, currentServerSideTableTimeStamp);
+ // This will occur if we have an older
SYSTEM.CATALOG and we need to update it to include
+ if(currentServerSideTableTimeStamp <
MetaDataProtocol.MIN_SYSTEM_TABLE_TIMESTAMP_4_3_0) {
+ // We know that we always need to
add the STORE_NULLS column for 4.3 release
+ columnsToAdd =
addColumn(columnsToAdd, PhoenixDatabaseMetaData.STORE_NULLS + " " +
PBoolean.INSTANCE.getSqlTypeName());
+ HTableDescriptor[]
localIndexTables = admin.listTables(MetaDataUtil.LOCAL_INDEX_TABLE_PREFIX+".*");
+ if
(table.getValue(MetaDataUtil.PARENT_TABLE_KEY) == null
{color:green}+1 core tests{color}. The patch passed unit tests in .
{color:red}-1 core zombie tests{color}. There are 1 zombie test(s):
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/524//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/524//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/524//console
This message is automatically generated.
> Create snapshot of system tables prior to upgrade and restore on any failure
> ----------------------------------------------------------------------------
>
> Key: PHOENIX-808
> URL: https://issues.apache.org/jira/browse/PHOENIX-808
> Project: Phoenix
> Issue Type: Task
> Reporter: James Taylor
> Assignee: Samarth Jain
> Attachments: PHOENIX-808.patch, PHOENIX-808_master.patch,
> PHOENIX-808_nowhitespace.patch, PHOENIX-808_v2.patch,
> PHOENIX-808_v2_master.patch, PHOENIX-808_v2_nowhitespacediff.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
