[ 
https://issues.apache.org/jira/browse/PHOENIX-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15437848#comment-15437848
 ] 

James Taylor commented on PHOENIX-3203:
---------------------------------------

Patch looks good, but can we also change the the GlobalCache API to use 
ImmutableBytesPtr so that this doesn't happen on accident again?
{code}
    public static TenantCache getTenantCache(RegionCoprocessorEnvironment env, 
ImmutableBytesPtr tenantId)
    public TenantCache getChildTenantCache(ImmutableBytesPtr tenantId) {
{code}


> Tenant cache lookup in Global Cache fails in certain conditions
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-3203
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3203
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.7.0
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 4.9.0, 4.8.1
>
>         Attachments: PHOENIX-3203.patch
>
>
> In ServerCachingEndpointImpl.addServerCache we look up the tenant cache using 
> an ImmutableBytesPtr instead of  ImmutableBytesWritable
> {code}
> ImmutableBytesPtr tenantId = null;
>     if (request.hasTenantId()) {
>       tenantId = new ImmutableBytesPtr(request.getTenantId().toByteArray());
>     }
>     TenantCache tenantCache = GlobalCache.getTenantCache(this.env, tenantId);
> {code}
> this causes the TenantCache to not be found when we look it up later using an 
> ImmutableBytesWritable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to