[ 
https://issues.apache.org/jira/browse/PHOENIX-3203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15438153#comment-15438153
 ] 

Hadoop QA commented on PHOENIX-3203:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12825544/PHOENIX-3203.patch
  against master branch at commit 9cc77c8104245a138a62ba251e926e14a74d8c11.
  ATTACHMENT ID: 12825544

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 
34 warning messages.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:green}+1 lineLengths{color}.  The patch does not introduce lines 
longer than 100

    {color:green}+1 core tests{color}.  The patch passed unit tests in .

Test results: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/538//testReport/
Javadoc warnings: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/538//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-PHOENIX-Build/538//console

This message is automatically generated.

> Tenant cache lookup in Global Cache fails in certain conditions
> ---------------------------------------------------------------
>
>                 Key: PHOENIX-3203
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3203
>             Project: Phoenix
>          Issue Type: Bug
>    Affects Versions: 4.7.0
>            Reporter: Thomas D'Silva
>            Assignee: Thomas D'Silva
>             Fix For: 4.9.0, 4.8.1
>
>         Attachments: PHOENIX-3203-v2.patch, PHOENIX-3203.patch
>
>
> In ServerCachingEndpointImpl.addServerCache we look up the tenant cache using 
> an ImmutableBytesPtr instead of  ImmutableBytesWritable
> {code}
> ImmutableBytesPtr tenantId = null;
>     if (request.hasTenantId()) {
>       tenantId = new ImmutableBytesPtr(request.getTenantId().toByteArray());
>     }
>     TenantCache tenantCache = GlobalCache.getTenantCache(this.env, tenantId);
> {code}
> this causes the TenantCache to not be found when we look it up later using an 
> ImmutableBytesWritable.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to