[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15491394#comment-15491394
 ] 

Eric Lomore commented on PHOENIX-3264:
--------------------------------------

As seen here, the Calcite SqlLiteral class doesn't have any support for 
booleans, and the error is caused by a fall through at the end.
!SqlLiteral.png!

I have coded up a fix by doing the boolean detection in the calling method 
instead (The SqlOptionNode constructor) but it seems more intuitive to 
implement this on the Calcite side (in SqlLiteral.value())
Is there a reason we don't have support for this on the calcite side, and do we 
want it to remain like that?
!SqlOptionNode.png!


Just trying to be careful since I'm not sure if these are Phoenix only 
features, or should also be in calcite :)
Thanks!

> Allow TRUE and FALSE to be used as literal constants
> ----------------------------------------------------
>
>                 Key: PHOENIX-3264
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3264
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>         Attachments: SqlLiteral.png, SqlOptionNode.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to