[ 
https://issues.apache.org/jira/browse/PHOENIX-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15513605#comment-15513605
 ] 

Eric Lomore commented on PHOENIX-3264:
--------------------------------------

Thanks for the help everyone! 
There is one last piece that is missing, it appears calcite is missing a public 
implementation for convertLiteral. Since Blackboard is a protected inner class 
there is no way to access it's convertLiteral implementation currently. It 
appears that a public access method never got added to its parent class, 
Sql2RelConverter.
I've attached a sample implementation below (untested, but the actual 
instantiation details of blackboard shouldn't matter as none of the passed 
parameters are used in the convert literal process)

!Sql2RelImplementation.png!

> Allow TRUE and FALSE to be used as literal constants
> ----------------------------------------------------
>
>                 Key: PHOENIX-3264
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3264
>             Project: Phoenix
>          Issue Type: Sub-task
>            Reporter: James Taylor
>         Attachments: Sql2RelImplementation.png, SqlLiteral.png, 
> SqlNodeToRexConverterImpl.png, SqlOptionNode.png, objectdependencies.png, 
> objectdependencies2.png, stacktrace.png
>
>
> Phoenix supports TRUE and FALSE as boolean literals, but perhaps Calcite 
> doesn't? Looks like this is leading to a fair number of failures.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to