[ 
https://issues.apache.org/jira/browse/PHOENIX-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15893536#comment-15893536
 ] 

Enis Soztutar commented on PHOENIX-3062:
----------------------------------------

When the metrics system gets restarted, it picks the new sinks from the 
properties file from the metrics system. I am not sure whether the tracing 
system is registered normally in that file. If it is, this is not a production 
issue then. Otherwise, you are right. 

On a separate note, tracing system piggy-backing on the metrics subsystem is 
not right. A simple bounded queue with a separate daemon thread would have 
solve the tracing use case. I think we should fix that for the long term. 

> JMXCacheBuster restarting the metrics system causes PhoenixTracingEndToEndIT 
> to hang
> ------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3062
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3062
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Enis Soztutar
>            Assignee: Enis Soztutar
>             Fix For: 4.10.0
>
>         Attachments: phoenix-3062_v1.patch
>
>
> With some recent fixes in the hbase metrics system, we are now affectively 
> restarting the metrics system (in HBase-1.3.0, probably not affecting 1.2.0). 
> Since we use a custom sink in the PhoenixTracingEndToEndIT, restarting the 
> metrics system loses the registered sink thus causing a hang. 
> We need a fix in HBase, and Phoenix so that we will not restart the metrics 
> during tests. 
> Thanks to [~sergey.soldatov] for analyzing the initial root cause of the 
> hang. 
> See HBASE-14166 and others. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to