[ https://issues.apache.org/jira/browse/PHOENIX-3062?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15941409#comment-15941409 ]
Hadoop QA commented on PHOENIX-3062: ------------------------------------ {color:red}-1 overall{color}. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12860472/PHOENIX-3062_v2.patch against master branch at commit 2074d1f0a2dd2b03c2e3588ffd4d5f2395cc7505. ATTACHMENT ID: 12860472 {color:green}+1 @author{color}. The patch does not contain any @author tags. {color:green}+1 tests included{color}. The patch appears to include 3 new or modified tests. {color:green}+1 javac{color}. The applied patch does not increase the total number of javac compiler warnings. {color:red}-1 javadoc{color}. The javadoc tool appears to have generated 50 warning messages. {color:green}+1 release audit{color}. The applied patch does not increase the total number of release audit warnings. {color:red}-1 lineLengths{color}. The patch introduces the following lines longer than 100: + Connection connection = new CountDownConnection(getConnectionWithoutTracing(), latch); + traceWriterExtends = new TraceWriterExtends(generateUniqueName(), defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest); + traceWriterExtends = new TraceWriterExtends(tableName, defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest); + traceWriterExtends = new TraceWriterExtends(tableName, defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest); + Span span = createNewSpan(traceid, Span.ROOT_SPAN_ID, 10, "root", 12, 13, "Some process", "test annotation for a span"); + traceWriterExtends = new TraceWriterExtends(tableName, defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest); + assertEquals("Didn't get expected annotation", count + " - " + Bytes.toString(entry.getValue()), + traceWriterExtends = new TraceWriterExtends(tracingTableName, defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest); + traceWriterExtends = new TraceWriterExtends(tracingTableName, defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest); + traceWriterExtends = new TraceWriterExtends(tracingTableName, defaultTracingThreadPoolForTest, defaultTracingBatchSizeForTest); {color:red}-1 core tests{color}. The patch failed these unit tests: ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.tx.FlappingTransactionIT Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/811//testReport/ Javadoc warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/811//artifact/patchprocess/patchJavadocWarnings.txt Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/811//console This message is automatically generated. > JMXCacheBuster restarting the metrics system causes PhoenixTracingEndToEndIT > to hang > ------------------------------------------------------------------------------------ > > Key: PHOENIX-3062 > URL: https://issues.apache.org/jira/browse/PHOENIX-3062 > Project: Phoenix > Issue Type: Bug > Reporter: Enis Soztutar > Assignee: Karan Mehta > Fix For: 4.11.0 > > Attachments: phoenix-3062_v1.patch, PHOENIX-3062_v2.patch > > > With some recent fixes in the hbase metrics system, we are now affectively > restarting the metrics system (in HBase-1.3.0, probably not affecting 1.2.0). > Since we use a custom sink in the PhoenixTracingEndToEndIT, restarting the > metrics system loses the registered sink thus causing a hang. > We need a fix in HBase, and Phoenix so that we will not restart the metrics > during tests. > Thanks to [~sergey.soldatov] for analyzing the initial root cause of the > hang. > See HBASE-14166 and others. -- This message was sent by Atlassian JIRA (v6.3.15#6346)