[
https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15992862#comment-15992862
]
Hadoop QA commented on PHOENIX-3822:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12865961/PHOENIX-3822.patch
against master branch at commit 5b099014446865c12779f3882fd8b407496717ea.
ATTACHMENT ID: 12865961
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 7 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated
46 warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ return new HashJoinPlan(statement, plan, joinInfo, subPlans,
joinInfo == null, Collections.<SQLCloseable>emptyList(), 0l, 0l);
+ return new HashJoinPlan(statement, hashJoinPlan.delegate, joinInfo,
mergedSubPlans, true, hashJoinPlan.dependencies, estBytes, estRows);
+ QueryPlan plan, HashJoinInfo joinInfo, SubPlan[] subPlans, boolean
recompileWhereClause, List<SQLCloseable> dependencies, Long estBytes, Long
estRows) {
+ PNameFactory.newName(EXPLAIN_PLAN_BYTES_COLUMN_NAME),
PNameFactory.newName(EXPLAIN_PLAN_FAMILY), PLong.INSTANCE, null, null, false, 1,
+ SortOrder.getDefault(), 0, null, false, null, false, false,
Bytes.toBytes(EXPLAIN_PLAN_BYTES_COLUMN_NAME));
+ PNameFactory.newName(EXPLAIN_PLAN_ROWS_COLUMN_NAME),
PNameFactory.newName(EXPLAIN_PLAN_FAMILY), PLong.INSTANCE, null, null, false, 2,
+ SortOrder.getDefault(), 0, null, false, null, false, false,
Bytes.toBytes(EXPLAIN_PLAN_ROWS_COLUMN_NAME));
+ new ExpressionProjector(EXPLAIN_PLAN_ALIAS,
EXPLAIN_PLAN_TABLE_NAME, new RowKeyColumnExpression(
+ EXPLAIN_PLAN_BYTES_COLUMN_ALIAS,
EXPLAIN_PLAN_TABLE_NAME, new KeyValueColumnExpression(
+ EXPLAIN_PLAN_ROWS_COLUMN_ALIAS,
EXPLAIN_PLAN_TABLE_NAME, new KeyValueColumnExpression(
{color:red}-1 core tests{color}. The patch failed these unit tests:
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/842//testReport/
Javadoc warnings:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/842//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/842//console
This message is automatically generated.
> Surface byte and row estimates in a machine readable way when doing EXPLAIN
> PLAN
> --------------------------------------------------------------------------------
>
> Key: PHOENIX-3822
> URL: https://issues.apache.org/jira/browse/PHOENIX-3822
> Project: Phoenix
> Issue Type: Improvement
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-3822.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
