[ 
https://issues.apache.org/jira/browse/PHOENIX-3822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16012964#comment-16012964
 ] 

James Taylor commented on PHOENIX-3822:
---------------------------------------

Thanks for the patch, [~samarthjain]. Tests look good. We shouldn't copy/paste 
that gnarly 100 lines of code into ScanUtil.getEstimatedRowsAndBytesToScan(), 
though. Instead, I think we can refactor it into ScanUtil and have the new 
method return an instance of a new class such as ScanInfo to encapsulate the 
estimates plus the List<List<Scan>> information. If that's problematic, we 
should just leave the byte/row estimate info in BaseResultIterators and access 
it from QueryPlan and AggregatePlan like we currently do.

> Surface byte and row estimates in a machine readable way when doing EXPLAIN 
> PLAN
> --------------------------------------------------------------------------------
>
>                 Key: PHOENIX-3822
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-3822
>             Project: Phoenix
>          Issue Type: Improvement
>            Reporter: Samarth Jain
>            Assignee: Samarth Jain
>         Attachments: PHOENIX-3822.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.3.15#6346)

Reply via email to