[
https://issues.apache.org/jira/browse/PHOENIX-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16018022#comment-16018022
]
Josh Elser commented on PHOENIX-3655:
-------------------------------------
bq. Not sure we are being fair to the contributor in broadening the scope of
work to add metrics to the PQS into a revamp of how Phoenix does metrics.
And I'm not sure how what I suggested was interpreted as all of Phoenix :)
All I suggested was that, for making these metrics available from PQS, we
should use existing libraries to export those metrics than building our own.
This doesn't imply a rewrite of how Phoenix collects and aggregates metrics --
just the reporting side which is what this ticket is doing.
I don't see this as being that onerous, but perhaps I'm jaded having worked
with multiple metrics libraries prior. I am also just one voice. If others
think what Rahul has presented in the reviews is sufficient, I am more than
happy to let them take over the review :)
> Metrics for PQS
> ---------------
>
> Key: PHOENIX-3655
> URL: https://issues.apache.org/jira/browse/PHOENIX-3655
> Project: Phoenix
> Issue Type: New Feature
> Affects Versions: 4.8.0
> Environment: Linux 3.13.0-107-generic kernel, v4.9.0-HBase-0.98
> Reporter: Rahul Shrivastava
> Assignee: Rahul Shrivastava
> Fix For: 4.9.0
>
> Attachments: MetricsforPhoenixQueryServerPQS.pdf
>
> Original Estimate: 240h
> Remaining Estimate: 240h
>
> Phoenix Query Server runs a separate process compared to its thin client.
> Metrics collection is currently done by PhoenixRuntime.java i.e. at Phoenix
> driver level. We need the following
> 1. For every jdbc statement/prepared statement/ run by PQS , we need
> capability to collect metrics at PQS level and push the data to external sink
> i.e. file, JMX , other external custom sources.
> 2. Besides this global metrics could be periodically collected and pushed to
> the sink.
> 2. PQS can be configured to turn on metrics collection and type of collect (
> runtime or global) via hbase-site.xml
> 3. Sink could be configured via an interface in hbase-site.xml.
> All metrics definition https://phoenix.apache.org/metrics.html
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
