Github user JamesRTaylor commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/239#discussion_r118314328
--- Diff:
phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java
---
@@ -192,6 +196,18 @@ public static void setOutputTableName(final
Configuration configuration, final S
public static void setUpsertColumnNames(final Configuration
configuration,final String[] columns) {
setValues(configuration, columns, MAPREDUCE_UPSERT_COLUMN_COUNT,
MAPREDUCE_UPSERT_COLUMN_VALUE_PREFIX);
}
+
+ public static void setSnapshotNameKey(final Configuration
configuration, final String snapshotName) {
+ Preconditions.checkNotNull(configuration);
+ Preconditions.checkNotNull(snapshotName);
+ configuration.set(SNAPSHOT_NAME_KEY, snapshotName);
--- End diff --
The idea of having the snapshot name in the configuration is not going to
translate well when we want to expose snapshot reads for queries in general as
the configuration is a global object.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
