Github user JamesRTaylor commented on a diff in the pull request:

    https://github.com/apache/phoenix/pull/239#discussion_r118314856
  
    --- Diff: 
phoenix-core/src/main/java/org/apache/phoenix/iterate/RegionContext.java ---
    @@ -0,0 +1,15 @@
    +package org.apache.phoenix.iterate;
    +
    +import org.apache.hadoop.hbase.coprocessor.RegionCoprocessorEnvironment;
    +
    +/**
    + * Maintains coprocessor environment state to
    + * make region observer functionality work for
    + * non-coprocessor environment
    + */
    +public interface RegionContext {
    +
    +  /** @return the Coprocessor environment */
    +  RegionCoprocessorEnvironment getEnvironment();
    --- End diff --
    
    If this is the only method, we don't really need this interface. Why not 
just keep using RegionCoprocessorEnvironment in our APIs and you can just 
instantiate you snapshot-based one prior to getting the RegionScanner?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to