[
https://issues.apache.org/jira/browse/PHOENIX-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16033653#comment-16033653
]
Samarth Jain commented on PHOENIX-3896:
---------------------------------------
[~karanmehta93] and I discussed offline and we agreed on the approach below:
- Have a separate spanReceiver for every test method, where the span receiver
for that test will be removed in an @After method. The same @After method will
also be shutting down the executor of the TestTraceWriter the test method is
using by calling stop() method. Changes that introduced the done member
variable are not really needed. So is not the overriden TestFlushMetrics class.
The stop() method inside TestTraceWriter should be modified to call APIs in the
right order. It should be something like this:
{code}
public void stop() {
try {
executor.shutdownNow();
executor.awaitTermination(5, TimeUnit.SECONDS);
} catch (InterruptedException e) {
LOG.error("Failed to stop the thread. ", e);
}
}
{code}
> Fix test failures related to tracing changes
> --------------------------------------------
>
> Key: PHOENIX-3896
> URL: https://issues.apache.org/jira/browse/PHOENIX-3896
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Karan Mehta
> Attachments: PHOENIX-3896.001.patch
>
>
> Looks like our unit tests are breaking after these commits:
> - PHOENIX-3248 Enable HBase server-side scan metrics to be returned to client
> and surfaced through metrics
> - PHOENIX-3752 Remove hadoop metrics integration from the tracing framework
> For example, see https://builds.apache.org/job/Phoenix-master/1628/ and
> https://builds.apache.org/job/Phoenix-4.x-HBase-1.1/405/.
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
