[
https://issues.apache.org/jira/browse/PHOENIX-3896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035623#comment-16035623
]
Samarth Jain commented on PHOENIX-3896:
---------------------------------------
Thanks for the patch, [~karanmehta93]. Patch looks good for the most part.
Below is some feedback:
In Tracing.java, do QueryServicesOptions.withDefaults() only once.
{code}
+ if (!initialized &&
QueryServicesOptions.withDefaults().isTracingEnabled()) {
......
QueryServicesOptions options =
QueryServicesOptions.withDefaults();
.....
}
{code}
I think exposing the spanQueue inside TraceSpanReceiver is a bit of abstraction
leak. You can add isSpanAvailable() and getSpan() methods in TraceReceiver
which internally call spanQueue.isEmpty() and spanQueue.poll() respectively.
In FlushMetrics class, please remove the log.info line
{code}
LOG.info("this: " + this + " Span received: " + span.toJson());
if(LOG.isTraceEnabled()) {
LOG.trace("Span received: " + span.toJson());
}
{code}
> Fix test failures related to tracing changes
> --------------------------------------------
>
> Key: PHOENIX-3896
> URL: https://issues.apache.org/jira/browse/PHOENIX-3896
> Project: Phoenix
> Issue Type: Bug
> Reporter: James Taylor
> Assignee: Karan Mehta
> Attachments: PHOENIX-3896.001.patch, PHOENIX-3896.002.patch,
> PHOENIX-3896.003.patch
>
>
> Looks like our unit tests are breaking after these commits:
> - PHOENIX-3248 Enable HBase server-side scan metrics to be returned to client
> and surfaced through metrics
> - PHOENIX-3752 Remove hadoop metrics integration from the tracing framework
> For example, see https://builds.apache.org/job/Phoenix-master/1628/ and
> https://builds.apache.org/job/Phoenix-4.x-HBase-1.1/405/.
>
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
