[
https://issues.apache.org/jira/browse/PHOENIX-3983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068747#comment-16068747
]
Vincent Poon commented on PHOENIX-3983:
---------------------------------------
The patch fixes the data table scans by specifically removing it from the
controller chain which sets the index priority. But should we try doing the
opposite? That is, instead of making a special case for non-index operations,
we should make a special case for index operations.
I think the current IndexRpcController is too broad in that it stamps all
non-system table operations with index priority. This could have unintended
consequences for users of HTable who have enabled the Phoenix
ServerRpcControllerFactory.
For instance, the canary and hbase shell use HTable as well, and they also read
from the server-side hbase-site.xml. Those requests would now get handled by
index handlers. Furthermore the operator would now have to know that they have
to adjust the IndexRPC handler pool size if they want to increase the pool for
server-server rpcs.
Having said that, I don't see an immediate easy solution :). The easiest would
be if in IndexRpcController we could determine from a TableName whether it is
an index, but we would have to pass in a special TableName to the HTable in the
IndexCommitter and then do an instanceof inside IndexRpcController.
> Index rebuild scans should not be using the ServerRpcControllerFactory
> ----------------------------------------------------------------------
>
> Key: PHOENIX-3983
> URL: https://issues.apache.org/jira/browse/PHOENIX-3983
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Samarth Jain
> Attachments: PHOENIX-3983.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
