[
https://issues.apache.org/jira/browse/PHOENIX-3994?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16083707#comment-16083707
]
Hadoop QA commented on PHOENIX-3994:
------------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12876778/PHOENIX-3994_v3.patch
against master branch at commit 4aac7fce629109d653384abcad38d48e15abb079.
ATTACHMENT ID: 12876778
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 3 new
or modified tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+
Mockito.verify(TestPhoenixIndexRpcSchedulerFactory.getIndexRpcExecutor(),
never()).dispatch(Mockito.any(CallRunner.class));
+ // Disable running upsert select on server side if a table has
global mutable secondary indexes on it
+ boolean hasGlobalMutableIndexes =
SchemaUtil.hasGlobalIndex(table) && !table.isImmutableRows();
+ runOnServer = (sameTable || (serverUpsertSelectEnabled &&
!hasGlobalMutableIndexes)) && isAutoCommit && !table.isTransactional()
+ LOG.error("Exception caught while trying to close the
HConnection used by CoprocessorHConnectionTableFactory");
+ LOG.debug("indexRegion.batchMutate failed
and fall back to HTable.batch(). Got error="
+ conf.set(RpcControllerFactory.CUSTOM_CONTROLLER_CONF_KEY,
InterRegionServerMetadataRpcControllerFactory.class.getName());
{color:red}-1 core tests{color}. The patch failed these unit tests:
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.CreateTableIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.UpsertSelectIT
Test results:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1201//testReport/
Console output:
https://builds.apache.org/job/PreCommit-PHOENIX-Build/1201//console
This message is automatically generated.
> Index RPC priority still depends on the controller factory property in
> hbase-site.xml
> -------------------------------------------------------------------------------------
>
> Key: PHOENIX-3994
> URL: https://issues.apache.org/jira/browse/PHOENIX-3994
> Project: Phoenix
> Issue Type: Bug
> Affects Versions: 4.11.0
> Reporter: Sergey Soldatov
> Assignee: Samarth Jain
> Priority: Critical
> Fix For: 4.12.0, 4.11.1
>
> Attachments: PHOENIX-3994_addendum.patch, PHOENIX-3994.patch,
> PHOENIX-3994_v2.patch, PHOENIX-3994_v3.patch
>
>
> During PHOENIX-3360 we tried to remove dependency on
> hbase.rpc.controllerfactory.class property in hbase-site.xml since it cause
> problems on the client side (if client is using server side configuration,
> all client request may go using index priority). Committed solution is using
> setting the controller factory programmatically for coprocessor environment
> in Indexer class, but it comes that this solution doesn't work because the
> environment configuration is not used for the coprocessor connection
> creation. We need to provide a better solution since this issue may cause
> accidental locks and failures that hard to identify and avoid.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
