[ 
https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16159064#comment-16159064
 ] 

James Taylor commented on PHOENIX-4138:
---------------------------------------

Patch looks good, but we need a test that hits the limit. Either a new test 
class derived from ParallelStatsDisabledIT or perhaps just adding a test to a 
non parameterized test class like IndexMetadataIT. Also, maybe a lower default 
of 10 is better. Having 20 indexes on a table sounds a bit scary. Should we do 
some perf testing around this, [~lhofhansl]?

> Create a hard limit on number of indexes per table
> --------------------------------------------------
>
>                 Key: PHOENIX-4138
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4138
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Rahul Shrivastava
>            Assignee: churro morales
>         Attachments: PHOENIX-4138.patch
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> There should be a config parameter to impose a hard limit on number of 
> indexes per table. There is a SQL Exception 
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260
>  , but it gets triggered on the server side  
> (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589)
>  . 
> We need a client side limit that can be configured via Phoenix config 
> parameter. Something like if user create more than lets say 30 indexes per 
> table, it would not allow more index creation for the that specific table. 



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to