[
https://issues.apache.org/jira/browse/PHOENIX-4138?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174005#comment-16174005
]
James Taylor commented on PHOENIX-4138:
---------------------------------------
Looks like the license header is in an unconventional place in
MetaDataEndpointImplTest. Can we move that to the top of the file?
bq. I can extract a code block to unit test this, that would be much faster and
it wouldn't add yet another integration test to slow down the suite. What do
you think about that?
There's not a lot of cost to a unit test, especially if you add it to an
existing test suite. How about a new test in CreateTableIT that adds 10
indexes? You could make them local indexes so that only a single physical HBase
table is created. The reason for the end to end unit test is to verify that
you've placed your check in a spot that is triggered when you expect it's
triggered.
> Create a hard limit on number of indexes per table
> --------------------------------------------------
>
> Key: PHOENIX-4138
> URL: https://issues.apache.org/jira/browse/PHOENIX-4138
> Project: Phoenix
> Issue Type: Bug
> Reporter: Rahul Shrivastava
> Assignee: churro morales
> Attachments: PHOENIX-4138.patch, PHOENIX-4138.v1.patch
>
> Original Estimate: 48h
> Remaining Estimate: 48h
>
> There should be a config parameter to impose a hard limit on number of
> indexes per table. There is a SQL Exception
> https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/exception/SQLExceptionCode.java#L260
> , but it gets triggered on the server side
> (https://github.com/apache/phoenix/blob/master/phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java#L1589)
> .
> We need a client side limit that can be configured via Phoenix config
> parameter. Something like if user create more than lets say 30 indexes per
> table, it would not allow more index creation for the that specific table.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
