Github user joshelser commented on a diff in the pull request:
https://github.com/apache/phoenix/pull/275#discussion_r144414821
--- Diff: phoenix-core/src/main/java/com/force/db/i18n/OracleUpper.java ---
@@ -0,0 +1,66 @@
+/*
--- End diff --
Yup! You got it right, James. Whether we include the code in binary form or
source form, for BSD, we treat them the same (propagate in LICENSE, and
copyright/etc in NOTICE). If there's a license header for the file, we would
also leave that, IIRC.---
