If the patches apply cleanly now, why wouldn't you commit them, especially the bigger ones that just switch to using non deprecated APIs. The timing is good because we just completed a release. If you wait, there will be bigger commits that come in making it more work for you to apply the patches later.
On Wed, Nov 15, 2017 at 11:57 PM, Ankit Singhal <[email protected]> wrote: > Yes, James, There are JIRAs(if not all) which are expected to be ported to > master soon like the JIRAs under > https://issues.apache.org/jira/browse/PHOENIX-4297. but as sometimes we > need a separate patch for HBase 2.0 and 1.x branch, which was delaying the > process of getting 5.x in a compiled state and such delay can lead us in a > loop of re-work as new development ported to this branch may not be well > tested. so, Plan is to have 5.x compiled and tested first by next week and > then concentrate on porting these changes back to 4.x. > > > On Wed, Nov 15, 2017 at 10:48 PM, James Taylor <[email protected]> > wrote: > > > There's a bunch of commits going into 5.x branch (which is great), but I > > don't see those being back ported to our master branch. Would it be > > possible to do that so we can keep the 4.x line in line with 5.x as much > as > > possible? > > >
