[
https://issues.apache.org/jira/browse/PHOENIX-3955?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16498319#comment-16498319
]
ASF GitHub Bot commented on PHOENIX-3955:
-----------------------------------------
GitHub user ChinmaySKulkarni opened a pull request:
https://github.com/apache/phoenix/pull/304
PHOENIX-3955: Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL
properties stay in sync between the physical data table and index tables
**[DO NOT MERGE - WIP patch]**
- Disallow specifying TTL, KEEP_DELETED_CELLS and REPLICATION_SCOPE at
column family level when creating table and also while creating indexes
- Sync these properties in create index code path after checking for
sync of existing column families in data table
- Modified alter table and alter global index code path to ensure
syncing of properties
- Added syncing properties of column families of tables and their
indexes as a step in execute upgrade code path
TODO:
- Add local testing that has been done
- Test old client new server and execute upgrade
- Handle indexes on views
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ChinmaySKulkarni/phoenix PHOENIX-3955
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/phoenix/pull/304.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #304
----
commit a370da3ecf1692fbed36463c184e1f4953ad545e
Author: Chinmay Kulkarni <chinmayskulkarni@...>
Date: 2018-06-01T17:36:36Z
PHOENIX-3955: Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL
properties stay in sync between the physical data table and index tables
[DO NOT MERGE - WIP patch]
- Disallow specifying TTL, KEEP_DELETED_CELLS and REPLICATION_SCOPE at
column family level when creating table and also while creating indexes
- Sync these properties in create index code path after checking for
sync of existing column families in data table
- Modified alter table and alter global index code path to ensure
syncing of properties
- Added syncing properties of column families of tables and their
indexes as a step in execute upgrade code path
TODO:
- Did lots of local testing for corner cases. Need to add tests
- Test old client new server and execute upgrade
- Handle indexes on views
----
> Ensure KEEP_DELETED_CELLS, REPLICATION_SCOPE, and TTL properties stay in sync
> between the physical data table and index tables
> ------------------------------------------------------------------------------------------------------------------------------
>
> Key: PHOENIX-3955
> URL: https://issues.apache.org/jira/browse/PHOENIX-3955
> Project: Phoenix
> Issue Type: Bug
> Reporter: Samarth Jain
> Assignee: Chinmay Kulkarni
> Priority: Major
>
> We need to make sure that indexes inherit the REPLICATION_SCOPE,
> KEEP_DELETED_CELLS and TTL properties from the base table. Otherwise we can
> run into situations where the data was removed (or not removed) from the data
> table but was removed (or not removed) from the index. Or vice-versa. We also
> need to make sure that any ALTER TABLE SET TTL or ALTER TABLE SET
> KEEP_DELETED_CELLS statements propagate the properties to the indexes too.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
